Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ISSUE_TRIAGE.md #6637

Closed
wants to merge 1 commit into from
Closed

Update ISSUE_TRIAGE.md #6637

wants to merge 1 commit into from

Conversation

vavole
Copy link
Contributor

@vavole vavole commented Sep 4, 2024 •
edited by lrapoport-cf
Loading

Fixes: N/A.
Minor syntactic changes on ISSUE_TRIAGE.md

What this PR solves / how to test

Adds commas here and there on the file.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: just a change to readme
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: just a change to readme
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: just a change to readme
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: just a change to readme

@vavole
Update ISSUE_TRIAGE.md
fb8c8e5 
Minor syntactic changes on ISSUE_TRIAGE.md
@vavole vavole requested a review from a team as a code owner September 4, 2024 17:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: fb8c8e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-wrangler-6637

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6637/npm-package-wrangler-6637

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-wrangler-6637 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-create-cloudflare-6637 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-cloudflare-kv-asset-handler-6637
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-miniflare-6637
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-cloudflare-pages-shared-6637
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-cloudflare-vitest-pool-workers-6637
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-cloudflare-workers-editor-shared-6637
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10706832662/npm-package-cloudflare-workers-shared-6637

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@lrapoport-cf lrapoport-cf added the skip-pr-description-validation Skip validation of the required PR description format label Sep 23, 2024
@lrapoport-cf lrapoport-cf mentioned this pull request Sep 23, 2024
Closed
@lrapoport-cf
Copy link
Contributor

@vavole can you please resolve conflicts?

@vavole vavole closed this by deleting the head repository Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

Assignees
No one assigned
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vavole @lrapoport-cf @penalosa